-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build system: cygwin/mingw #271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CMakeLists.txt # modules/nwtc-library/src/git.h.in
Until we have a proper license
Additionally, I found that Cygwin requires the Linux Sys file in order to properly load the dll's. This change has been added to the CMakeLists in nwtclib. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete this sentence
THIS PULL REQUEST IS NOT READY TO MERGE
Feature or improvement description
This pull request fixes some known issues in compiling and running OpenFAST with Cygwin and MinGW primarily in the MAP project. Also, the CMake configuration and documentation are updated. I started this branch from another branch which I've pull requested in #270. This should not be merged until that one is.
In MAP:
ifdef
In CMake:
This pull request is based off of #68 and supercedes it. Per @bjonkman's comments there, I've configured CMake to pass the appropriate compiler flags to MAP so that
cminpack
is not modified. These compiler flags were found in the MAP makefile, and thats where_MINGW
is set. However, this compiler flag is only used in mapsys.h to adddllexport
. Is there any reason to not use__MINGW32__
there and remove this single-use compiler flag altogether? On @bjonkman's second comment, this pull request adds the missing flag but I'm wondering if its actually needed.Related issue, if one exists
#144
Impacted areas of the software
MAP, CMake configuration, and documentation
Additional supporting information
None
Test results, if applicable
Here are the results from the regression tests involving MAP on my Mac:
On Windows with MinGW, there aren't a set of appropriate baseline solutions so all tests are not expected to pass. Below are the results from running one of the MAP tests:
Rather than validating the solution, I think its sufficient to validate that the tests case finished successfully, so here's the log file from the regression test: