Fix InflowWind index for invalid channels + typo in HydroDyn echo file #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an invalid channel name is selected, InflowWind uses a default index of 0. However, the `m%Allouts` array it was indexing into started with 1 instead of 0.
jjonkman
approved these changes
Mar 21, 2019
|
Thanks @bjonkman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PULL REQUEST IS READY TO MERGE
Feature or improvement description
This fixes a small typo in the HydroDyn variable description for
SumQTF, and fixes a larger issue where InflowWind could produce a segmentation fault due to an incorrect index if a user requested an invalid output channel.Impacted areas of the software
SumQTFline.Automated test results
This should not affect any of the test results.