-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new routine and variables to init in the ADI_c_binding interface #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input file for the |
073a6fb
to
9ad2197
Compare
bb118a2
to
2052f62
Compare
deslaughter
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
ADI_C_GetDiskAvgVel
WrVTK_DT
to initialization to set the timestep between VTK writes. The ADI c-bindings library interface has not had a method setting a timestep between visualization VTK file writes. This results in a massive number of files if the timestep is small.OutVTKdir
to the initialization so that the VTK output directory can be specified. This can be an absolute path, or a path relative to the ADI input files. If this variable is empty,vtk-ADI
is used (previous behavior).adilib
inCMakeLists.txt
AeroDyn_Driver_Subs.f90
file for better clarity and consistency with other codesRelated issue, if one exists
None. This was by request of an external user.
Impacted areas of the software
This changes the interface to the ADI c-bindings library.
Test results, if applicable
The test results do not change, but the py_AD driver files change slightly