Bug Fix: AD: projection method should now depend on BEM_Mod #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged.
Feature or improvement description
For BEM_Mod to be working properly, AeroDyn needs to change the AeroDyn Projection Method based on BEM_Mod. To achieve this, teh OpenFAST driver needs to set the AeroDyn Projection Method to -1 "automatic".
The projection method is an input to AeroDyn to allow the AeroDyn driver to change it (e.g. for vertical axis turbines).
We will likely be able to simplify the code logic in the future by:
Related issue, if one exists
Somehow related to the discussion found #2349
Impacted areas of the software
AeroDyn with
BEM_Mod=2