Fixes #254 - Updates the testing documentation for Windows with instructions to copy r-test folder #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocumentation with inclusion of an instruction to copy the r-test folder to build/reg_tests
…ression test' of the documentation
…g-test_Doc_update
rafmudaf
approved these changes
Mar 7, 2019
There was a problem hiding this comment.
Unfortunately, the executable naming for the vs-build method is dependent on the build type so for some people it will be openfast_x64.exe while for others it will include Double. Lets leave your changes as they are and keep that in mind for future revisions of the documentation.
Thanks a lot for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PULL REQUEST IS READY TO MERGE
Feature or improvement description
In section 5.2.3. of the documentation ("Windows with Visual Studio regression test") an instruction is missing, that one needs to copy the contents of
openfast/reg_tests/r-testintoopenfast/build/reg_teststo be able to run the regression test with the python scriptmanualRegressionTest.py. This issue is fixed with this pull request by updating the file\docs\source\testing\regression_test_windows.rst.Additionally, with the Visual Studio solution currently provided for compiling OpenFAST, the compiled executable will be named
openfast_x64_Double.exe, when choosing Release_Double and x64. This pull request also updates section 5.2.3. of the documentation according to this fact..Related issue, if one exists
#254