[BugFix] Incorrect value of AirDens passed to ExtInfw_Init from FAST_Subs.f90 #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExtInfw was incorrectly receiving a 0 for the air density due to a logic error introduced when ExtInfw_Init was relocated to after AeroDyn Also add AirDens initialization output from AeroDisk (this gets passed to ServoDyn)
7e20470 to
a56ca91
Compare
deslaughter
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
Due to a logic error, the
AirDensvalue passed to ServoDyn and External-Inflow was set to zero. The logic around zeroing out theAirDensvalue was corrected.Also I noticed that AeroDisk was not returning a value for
AirDensduring initialization. Since AeroDisk can use its own value instead of the value set in the main .fst file, this value should be returned so that ServoDyn has the correct air density.Related issue, if one exists
None (issue found by @marchdf and notified us internally)
Impacted areas of the software
This primarily affects the
ExtInfwmodule used for actuator line coupling with Nalu-Wind, but could potentially show up with any controller that uses the air density (none of our test controllers use it).Test results, if applicable
None: our test controllers do not use the air density.