Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HydroDyn user documentation update for large platform rotation #2455

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

luwang00
Copy link
Contributor

@luwang00 luwang00 commented Oct 8, 2024

Feature or improvement description

  • This PR updates the HydroDyn user documentation to reflect the recent input file changes for the modeling of large platform yaw motion.
  • It also updates error messages, variable descriptions, and comments in HydroDyn to match the finalized implementation of large platform rotation.

Related issue, if one exists
This is the documentation update for PR #2203

Impacted areas of the software
Docs, HydroDyn

Test results, if applicable
The changes have no impact on the results.

@andrew-platt andrew-platt self-assigned this Oct 8, 2024
@andrew-platt andrew-platt self-requested a review October 8, 2024 23:08
@andrew-platt andrew-platt added this to the v4.0.0 milestone Oct 8, 2024
@luwang00
Copy link
Contributor Author

luwang00 commented Oct 8, 2024

@andrew-platt Looks like we have the wrong label here.

@andrew-platt
Copy link
Collaborator

Whoops. I was looking at something in AeroDyn when I set the tag...

Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great! Please find a couple minor comments below.

0 ExctnDisp - Method of computing Wave Excitation {0: use undisplaced position, 1: use displaced position, 2: use low-pass filtered displaced position) [only used when PotMod=1 and ExctnMod>0 and SeaState's WaveMod>0]} (switch)
10 ExctnCutOff - Cutoff (corner) frequency of the low-pass time-filtered displaced position (Hz) [>0.0] [used only when PotMod=1, ExctnMod>0, and ExctnDisp=2]) [only used when PotMod=1 and ExctnMod>0 and SeaState's WaveMod>0]} (switch)
0 PtfmYMod - Model for large platform yaw offset {0: Static reference yaw offset based on PtfmRefY, 1: dynamic reference yaw offset based on low-pass filtering the PRP yaw motion with cutoff frequency PtfmYCutOff} (switch)
0 PtfmRefY - Constant (if PtfmYMod=0) or initial (if PtfmYMod=1) platform reference yaw offset (deg)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably this angle should be in the [-180, 180) deg range?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PtfmRefY does not need to be strictly between [-180,180), not intentionally at least. Integer multiples of 360 deg are added as appropriate at various places in the code to handle this.

still allowing the simulation to continue if possible.

With **PtfmYMod** = 1, HydroDyn requires the first- and second-order
potential-flow wave excitation input file(s) to cover the full range
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought second-order must be disabled with PtfmYMod =1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should still support mean- and slow-drift loads through MnDrift or NewmanApp. This is explained below, but I added a clarification here as well.

…ly works with mean- or slow-drift loads from Newman's approximation
@andrew-platt andrew-platt merged commit f4d0e92 into OpenFAST:dev Oct 21, 2024
21 checks passed
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
38 tasks
@luwang00 luwang00 deleted the d/HD_Doc_LrgYaw branch December 24, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants