Adding safety on number of lines and number of fields per line when WaveMode=6 (Should Fix #118) #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aveMod=6 (Should Fix OpenFAST#118)
|
@ghaymanNREL I've looked over this pull request and it looks fine to me. Could you give it a second review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PULL REQUEST IS READY TO MERGE
Feature or improvement description
Input files are now checked for sufficient number of lines, and each line is checked to see if enough columns are provided. Explicit error messages with recommendations are provided.
The format is still rather flexible. One line of comment is required at the beginning of the file.
The file should then contain
n x mvalues space, or comma separated, withn>=WaveTMax/WaveDtandm>=NNodes(the number of internal HydroDyn Nodes. If we want strict equality, it's a bit more work.Related issue, if one exists
See #118
Impacted areas of the software
HydroDyn with
WaveMod=6Automated test results
None, but the safety checks can be tried by removing some data in the input file (either a line or a single field), and HydroDyn should now mention where the data is missing in the file.