Setting last value of WaveDirArr (Closes #236) #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 7, 2019
jjonkman
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
We discussed this via e-mail and I'm fine with this change. Simply setting
InitOut%WaveDirArr(InitOut%NStepWave2)=0.0_ReKi
would also be fine because for the time series process to be real with zero mean, the values of the wave spectrum at Omega = 0.0 and Omega = NStepWave2*WaveDOmega (= WaveOmegaMax) must be zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PULL REQUEST IS READY TO MERGE
Feature or improvement description
Fixes #236
Related issue, if one exists
See #236
Impacted areas of the software
Impacts HydroDyn but impact is minor since only the last value of the array (i.e the last frequency) had an erroneous wave direction in.