SeaState: replace pointer attribute with allocatable
#2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These arrays are not pointers (they were at one iteration of the SeaState evolution), and our gnu compiler complained
pointer attribute with allocatablepointer attribute with allocatable
andrew-platt
approved these changes
Mar 25, 2024
3e49c67
into
OpenFAST:dev-unstable-pointers
40 of 42 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Fix pointer/allocatable attributes in one SeaState function. At one point in the SeaState evolution, these arrays were pointers, but they later were allocatable.
Related issue, if one exists
Impacted areas of the software
SeaState, mostly as called from the SeaState driver
Additional supporting information
It's possible this was missed because this code isn't called in OpenFAST without changing a hard-coded parameter.
Test results, if applicable
Should not change any tests. This will only cause the build to fail on certain compilers.