Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More bug fixes in the WAMIT and WAMIT2 modules of HydroDyn with wave headings #2098

Merged

Conversation

luwang00
Copy link
Contributor

@luwang00 luwang00 commented Mar 15, 2024

Feature or improvement description
The PR contains several bug fixes for the WAMIT and WAMIT2 modules of HydroDyn. The bugs are related to the handling of wave headings,

In WAMIT:

  • When NBodyMod=2, PtfmRefztRot was not accounted for when checking the WAMIT wave headings.
  • The previous correction of WAMIT wave heading when NBodyMod=2 will lead to interpolating out of range.
  • The phase shift of wave elevation for the state-space wave-excitation model was implemented incorrectly.

In WAMIT2:

  • The checking of WAMIT wave frequencies were not functioning as intended and were unnecessary. This is simply removed.
  • The checking of WAMIT wave headings is moved to separate subroutines to minimize code duplication.
  • The checking of WAMIT wave headings did not account for PtfmRefztRot when NBodyMod=2. This is now corrected.

Impacted areas of the software
HydroDyn

Test results, if applicable
No change to existing test results. Will need more r-tests in the future to cover the various options of HydroDyn.

@luwang00 luwang00 changed the title More bug fixes in the WAMIT module of HydroDyn associated with wave headings More bug fixes in the WAMIT and WAMIT2 modules of HydroDyn with wave headings Mar 15, 2024
@andrew-platt andrew-platt self-assigned this Mar 20, 2024
@andrew-platt andrew-platt self-requested a review March 20, 2024 15:59
@andrew-platt andrew-platt added this to the v4.0.0 milestone Mar 20, 2024
Copy link
Collaborator

@andrew-platt andrew-platt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing this!

@andrew-platt andrew-platt merged commit d697b43 into OpenFAST:dev-unstable-pointers Mar 26, 2024
83 of 84 checks passed
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants