Move flag for WriteThisStep to FAST_PreWork #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the glue code, a flag `WriteThisStep` indicates when to write output to files (or store outputs). This had been in `FAST_Solution`, but should be located in `FAST_PreWork` (it was left in `FAST_Solution` when that routine was split into several parts). Co-authored-by: bjonkman <bonnie.jonkman@envision-energy.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready to merge.
Feature or improvement description
In the glue code, a flag
WriteThisStepindicates when to write output to files (or store outputs). This had been inFAST_Solution, but should be located inFAST_PreWork(it was left inFAST_Solutionwhen that routine was split into several parts).Related issue, if one exists
https://github.com/OpenFAST/openfast/pull/1932/files#r1513534370
Impacted areas of the software
Potential impacts on writing to file when an external code directly calls the OpenFAST routines called by
FAST_Solution(for example, AMR-Wind).Additional supporting information
When
FAST_Solutionwas split into multiple routines during the addition of theExtLoadsmodule, this statement should have been included in the newFAST_PreWorkroutine, but was not.