Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeaSt Vis: corrections to PR #1992 #2071

Conversation

andrew-platt
Copy link
Collaborator

Ready for merging

Feature or improvement description
A few minor issues were noted with PR #1992 after it was merged.

  • minor typos
  • leftover debugging statement

Related issue, if one exists
PR #1992

Impacted areas of the software
SeaState grid visualization.

Additional supporting information
During later review, @bjonkman found a few minor errors.

Test results, if applicable
No changes.

A few minor issues were noted with PR OpenFAST#1992 after it was merged.

Co-authored-by: bjonkman <bonnie.jonkman@envision-energy.com>
@andrew-platt andrew-platt added the Module: SeaState SeaState module for wave data generation label Mar 5, 2024
@andrew-platt andrew-platt added this to the v4.0.0 milestone Mar 5, 2024
@andrew-platt andrew-platt self-assigned this Mar 5, 2024
@andrew-platt
Copy link
Collaborator Author

@bjonkman, I addressed your comments on PR #1992 here.

@bjonkman
Copy link
Contributor

bjonkman commented Mar 5, 2024

@bjonkman, I addressed your comments on PR #1992 here.

Thanks, @andrew-platt! As annoying as it is to merge our differing code bases these days, it does give an extra set of eyes on changes. :-)

@andrew-platt andrew-platt merged commit 850aae1 into OpenFAST:dev-unstable-pointers Mar 5, 2024
21 checks passed
@andrew-platt andrew-platt deleted the b/CorrectionsToPR1992 branch March 7, 2024 23:53
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: SeaState SeaState module for wave data generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants