ExtLoads module: Use pointers for wind #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ExtLoads_pointers
deslaughter
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs testing with AMR-Wind to confirm it works as expected.
Feature or improvement description
The ExtLoad module was developed prior to the introduction of pointers for accessing InflowWind data. That worked on the
devbranch, but the introduction of pointers on thedev-unstable-pointersbranch was incompatible with the original implementation. PR #2008 merges thedevbranch, which includes the new ExtLoad module, into thedev-unstable-pointersbranch, but effectively breaks the ExtLoad module due to the incompatibility. This PR updates the ExtLoad module integration to set wind information in the new framework. This PR should only be merged after #2008.Related issue, if one exists
PR #2008
Impacted areas of the software
The functionality of the ExtLoad module used with AMR-Wind for blade resolved cfd loads.
Additional supporting information
This update is based on a similar modification of the ExternalInflow module.
Test results, if applicable
Unfortunately we do not have any tests that exercise this code as it requires coupling to CFD, which is beyond the scope of our testing. @gantech may be able to help with verifying this does not break the AMR-Wind integration.