ExtLoads: move integers from inputs to parameters #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 22, 2024
|
This sounds like a very reasonable fix. I'll give this a shot. |
|
New branch is working as expected and combined FSI simulation runs! Please merge! |
gantech
approved these changes
Jan 25, 2024
deslaughter
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready to merge pending testing by @gantech.
Feature or improvement description
The implementation of the ExtLoads module from PR #1932 included integers in the
InputTypederived types, which is not allowed. This PR moves these integers into aParameterTypesince they do not change throughout the simulation.Related issue, if one exists
#1932 (comment)
Impacted areas of the software
Internal workings of the cpp interface for CFD blade resolved coupling through the ExtLoads module only.
Additional supporting information
The registry did not flag this as an issue during development or merge into the
devbranch. The issue was discovered when attempting to mergedevintodev-unstable-pointerswhere a newer registry is used. First attempt to resolve the issue with PR #1999 was abandoned in favor of a fix that does not violate the framework design (more uniform with other module implementations this way).Test results, if applicable
None