Ensure the estimated intersections between the free surface and the Morison members are treated as under water #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…put point to be treated as in water. This is needed when querying the wave kinematics at the estimated intersection between the free surface and a Morison member to ensure nonzero wave kinematics are returned.
…ave kinematics at a list of node positions. Update Morison_CalcOutput to use this new WaveField function.
andrew-platt
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
WaveFieldmodule (WaveField_GetWaveKinandWaveField_GetWaveVel) that can force the input point to be treated as in water. This is helpful when querying for the wave kinematics at the estimated intersections between the free surface and Morison members in HydroDyn in case the intersections are slightly above the free surface due to numerical error.Impacted areas of the software
SeaState and HydroDyn
Test results, if applicable
No change to existing test results.