[BugFix] HD wave visualization with 2nd order waves #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was reported in issue OpenFAST#1484
|
Closes #1484 |
jjonkman
approved these changes
Jun 13, 2023
This was referenced Oct 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reported in issue #1484
Feature or improvement description
There has been a bug in HydroDyn for some time that if surface visualization was turned on with second order waves, the simulation would abort.
Related issue, if one exists
This was reported in #1484.
Impacted areas of the software
This only affects visualization of surfaces when second order waves are turned on.
Additional supporting information
This bug has been in the code for some time -- at least since v 3.3.0, but perhaps earlier.
Test results, if applicable
No test results are affected (we don't extensively test the visualization on GitHub actions due to the resource expense).