-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More updates to the Morison module #1578
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for strip-theory members
…us with Cb This change avoids physically inconsistent hydrostatic load.
…of member cross sections with the free surface
…ember sections and the free surface
…lation Also fixed the error handling of the new subroutines in Morison_CalcOutput
…ntegration over each element
…e termination when the (sub)element bounds the waterplane
Need to use the instantaneous k vector.
8 tasks
andrew-platt
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r-tests will not pass. Need to update HydroDyn input files with the new buoyancy coefficient,$C_b$ , entries and the hydrostatic load model switch,
MHstLMod
. (See PR #100 to r-test)MHstLMod=0
.MHstLMod=1
.MHstLMod=2
.Feature or improvement description
MHstLMod=2
) based on numerical integration along the length of the member. This approach should support arbitrary intersection between the instantaneous free surface (or still water level if no wave stretching) and the strip-theory member, including partially wetted end plates.MHstLMod=1
) is more suitable for (nearly) vertical surface-piercing columns with the bottom end plate fully submerged and the top end plate dry at all times. Preferably the normal of the waterplane area is mostly aligned with the member axial direction. This method also works with fully submerged members.MHstLMod=2
) is more general but might be computationally more expensive.WaveStMod>0
andWaveDisp=1
.Related issue, if one exists
Impacted areas of the software
HydroDyn => The modifications are confined to the Morison submodule of HydroDyn.
Release checklist:
add regressions tests from private @luwang00 repository (new feature tests)this will be a separate PR for 4.0.0 (https://github.com/orgs/OpenFAST/projects/2?pane=issue&itemId=30000600)