[BugFix] InflowWind: native Bladed wind files and wind box rotation #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds regression tests for InflowWind native Bladed files and uniform wind files
When IfW was refactored, RefPosition was moved inside the Flow Field derived type; however, the code that set this value was not updated properly so RefPosition as always zero. This was missed by regression testing because the wind was not rotated. A new ifw_uniform test has been added to catch this in the future.
This code fixes several issues related to reading and initializing native Bladed wind flies. A new regression test has been added for this wind type to catch these errors in the future.
Using a select statement will allow the compiler to optimize this routine better
andrew-platt
approved these changes
Apr 21, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged.
Feature or improvement description
This PR fixes several bugs in InflowWind which were introduced with the restructuring PR (#1516):
Impacted areas of the software
InflowWind and related InflowWind module regression tests.
Test results, if applicable
Two regression tests were added for the InflowWind module:
ifw_nativeBladed- reads a native Bladed wind file and calculates flow field velocities at a selection of points, compares results with referenceifw_uniform- reads a Uniform wind file (.HH) and calculates flow field velocities at a selection of points, compares results with reference. The InflowWind input file also specifies andPropagationDirandVFlowAngto check that wind box rotation is properly implenmented.