Reader native schism #447
Closed
Reader native schism #447
+28,847
−1,130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @simonweppe,
Thank you very much. We are in the process of restructuring the readers
module to better accommodate unstructured readers. Since these are more
heterogeneous than regularily gridded, it will be a bit different from the
structured ones. The pr is here:
#436 . I think we should merge
the work in this pr afterwards, it should not be too difficult to adapt it.
Regards, Gaute
tor. 26. nov. 2020, 16:16 skrev simonweppe <notifications@github.com>:
… Hi @knutfrode <https://github.com/knutfrode> @gauteh
<https://github.com/gauteh> ,
Following up on that discussion on readers for data on unstructured grids,
#243 <#243>, I have made a
clean branch from your latest code (without any of my other edits/dev) and
added only work I did on the reader for the native SCHISM output files (
SCHISM model : http://ccrm.vims.edu/schismweb/. The interpolation is
handled by the ReaderBlockUnstruct() class, which is in the reader itself
rather than in interpolation.py for now
Like you said, it would be good to have a more generic reader for several
unstructured grid formats, but in the meantime this could be useful to
SCHISM users or in the development of a more unified reader for these kind
of grids.
Cheers,
Simon
------------------------------
You can view, comment on, or merge this pull request online at:
#447
Commit Summary
- adding schism reader and example
- adding shoreline file
File Changes
- *A* examples/example_schism_native.py
<https://github.com/OpenDrift/opendrift/pull/447/files#diff-a41fcaf9a6a6956cc1670e1217c1f5b6341e11d40165a18079550049350dfa67>
(62)
- *A* examples/schism_marl_edit.shore
<https://github.com/OpenDrift/opendrift/pull/447/files#diff-6544914a9f532cee965463c264a583b537587920089bb591783048d25fc47b72>
(24229)
- *A* opendrift/readers/reader_landmask_custom.py
<https://github.com/OpenDrift/opendrift/pull/447/files#diff-0c18420bb9e7b67a44d3e5ebc2f452de3c7ba0e0921137c13955b2cbdf3ecef4>
(296)
- *A* opendrift/readers/reader_netCDF_CF_unstructured_SCHISM.py
<https://github.com/OpenDrift/opendrift/pull/447/files#diff-5d89979258f17d71d65fe1aeb6e167ca249d85ed7cbd7951b31efee55b44911b>
(1346)
Patch Links:
- https://github.com/OpenDrift/opendrift/pull/447.patch
- https://github.com/OpenDrift/opendrift/pull/447.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#447>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN364O3CNU627U5OON553SRZWOPANCNFSM4UD3MLTQ>
.
|
Closed
|
Hi @simonweppe, I've started looking at this reader. I have posted some cleanups in #476 (currently only regarding the custom landmask). I have also rebased your work. We have made some significant changes to the structure and inheritance of readers which we need to take into account in your reader before we can merge. It would be good to remove debug comments and dead code before merging since this tends to end up never getting removed later. If you do not have time to do this I can also try to help out with that. I have not really started working on the schims-reader yet but I hope that some of the methods in unstrucutred.py can be used to avoid duplication between FVCOM and SCHISM. I have some doubts though since you need a 3D cKDTree. In custom landmask reader, do you need the plot method? I assume it is duplicated here since you need an unstructured boundary? Regards, Gaute |
|
Thanks for that @gauteh. I'll find some time to clean the code and include as much as possible the methods in unstrucutred.py. |
… performance improvement for one case. Added also the same chunk for open_dataset, but uncertain whether this has any impact.
Added chunks time:1 for open_mfdataset in reader_netCDF_generic. Huge…
…of oil_library which led to import trouble
…t on performance for thredds aggregates
Modified check whether environment is outdated; using cfgrib instead …
Radionuclide
…t example. ShipDrift model now requires wind and current input to run (fallback 0 -> None)
Using now CMEMS wind (MyWwaveWAM3km) and current (Topaz6) in shipdrif…
par lonlat2xy
…lel__ is used to disable parallel lonlat2xy
plot_property() can now save figure to file if filename is provided
netCDF attribute seed_geojson is now a GeoJSON FeatureCollection.
…ipt to show coverage of these for the gallery. Prioritising now Topaz6 in favor of Topaz4 and Nordic4, and WAM3 in favor of WAM4
… x/y variables are detected, giving much faster initialisation. General cleanup of the reader.
…on() method, activated by setting markersize='mass' when calling the method. (Otherwise the algorithm runs as before)
[run-ex] Illustrating use of orign_marker in example_multi_seed.py
Assuring that sea_floor_depth_below_sea_level is positive, and not ne…
Set resuspended particles diameter correctly
…dated for sorbed to sediments and then resuspended particles.
…n factors for temperature and salinity environmental variables. Renaming several variables
Chemical speciation for organic pollutants + some small fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @knutfrode @gauteh ,
Following up on that discussion on readers for data on unstructured grids, #243, I have made a clean branch from your latest code (without any of my other edits/dev) and added only work I did on the reader for the native SCHISM output files ( SCHISM model : http://ccrm.vims.edu/schismweb/. The interpolation is handled by the
ReaderBlockUnstruct()class, which is in the reader itself rather than ininterpolation.pyfor nowLike you said, it would be good to have a more generic reader for several unstructured grid formats, but in the meantime this could be useful to SCHISM users or in the development of a more unified reader for these kind of grids.
Cheers,
Simon