Hook mongosh conversion code into CLI
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekSi
reviewed
Mar 13, 2025
opendocdb-cts/main.go
Outdated
|
|
||
| b, err := mongosh.ConvertFixtures(fxs) | ||
|
|
||
| f, err := os.OpenFile(filepath.Join(cli.Convert.OutDir, "convert.js"), os.O_RDWR|os.O_CREATE|os.O_TRUNC, 0666) |
AlekSi
reviewed
Mar 16, 2025
opendocdb-cts/go.mod
Outdated
| @@ -10,6 +10,7 @@ require ( | |||
| github.com/neilotoole/slogt v1.1.0 | |||
| github.com/pmezard/go-difflib v1.0.0 | |||
| github.com/stretchr/testify v1.10.0 | |||
| go.mongodb.org/mongo-driver v1.17.3 | |||
AlekSi
reviewed
Mar 20, 2025
| return err | ||
| } | ||
|
|
||
| f, err := os.Create(filepath.Join(cli.Convert.OutDir, "convert.js")) |
There was a problem hiding this comment.
Why filename is fixed? Why it is a single file?
chilagrow
reviewed
Mar 21, 2025
| @@ -38,6 +40,10 @@ var cli struct { | |||
|
|
|||
| Fmt struct{} `cmd:"" help:"Reformat CTS files."` | |||
|
|
|||
| Convert struct { | |||
| OutDir string `type:"path" arg:"" help:"Output directory."` | |||
There was a problem hiding this comment.
Should it create a directory if it doesn't exist?
| @@ -58,6 +64,29 @@ func fmtCommand() error { | |||
| return data.SaveTestSuites(tss, cli.Dir, nil) | |||
| } | |||
|
|
|||
| // runCommand implements the "convert" command. | |||
| func convertCommand() error { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10.