First pass at singleton with active objects #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghutchis
reviewed
Aug 12, 2018
Uses new class from the Avogadro libraries to manage active objects. There is more detail in the avogadrolibs repository, but this is a very limited first use to track global active objects in a running application. The use of a singleton with active render widgets, etc, enables the plugins to have a minimal API, and use the singleton API if they need to gain access to things such as the active render widget to grab the frame buffer to generate an image, etc. Signed-off-by: Marcus D. Hanwell <marcus.hanwell@kitware.com>
|
I will be extending this out significantly, but wanted to test it in packages in a restricted use case. I added more detail to the commit message, it is a pattern I use in a number of big Qt C++ projects, and mirrors aspects of QCoreApplication/QApplication singletons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.