Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut configuration #955

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

letsfindaway
Copy link
Collaborator

This PR supersedes #686, which again is based on #460.

@letsfindaway
Copy link
Collaborator Author

@kaamui: what do you think about providing this PR without the configuration dialog? It contains some remarkable improvements for shortcut handling anyway:

  • Shortcuts for switching tools are active even when the tools palette is hidden. Currently the shortcuts no longer work when the palette is hidden using the top left button.
  • You can temporarily switch tools by pressing and holding the keys. Consider you are drawing something. When now pressing and holding the shortcut keys for the eraser, you can switch to the eraser. When you then release the keys, you are back to the previous tool. This function might also be useful for the laser pointer.
  • You can switch tools while drawing. You can e.g. start drawing using the pen, then while the mouse button is still down, you can press the shortcut for the line tool and continue with a straight line etc.
  • I think also the option to use the shortcuts without the Ctrl modifier is quite useful.

@kaamui
Copy link
Member

kaamui commented Aug 23, 2024

Hi @letsfindaway,

I think the configuration dialog need improvement, so I agree we could benefit the improvements you mentioned in the next release and separate it from the configuration dialog planned for 1.8. I have some feedback to give you, I simply didn't find the time to write them down.

Go for the two separate PRs !

@letsfindaway letsfindaway force-pushed the shortcut-configuration branch from 238cf59 to 4c2320d Compare August 25, 2024 13:53
@letsfindaway letsfindaway force-pushed the shortcut-configuration branch from 4c2320d to 8bc8bd3 Compare August 25, 2024 17:14
@letsfindaway letsfindaway force-pushed the shortcut-configuration branch from 8bc8bd3 to 01417d4 Compare September 5, 2024 14:55
@letsfindaway letsfindaway force-pushed the shortcut-configuration branch 2 times, most recently from ee1e43f to 94f0803 Compare September 30, 2024 14:22
- recording of key sequences amd mouse/stylus buttons
- collect actions, filtering, collision detection
- persist shortcut settings
- change ownership of a translation string in UBShortcutManager
- add new translation strings
- update a few translations
@letsfindaway letsfindaway force-pushed the shortcut-configuration branch from 94f0803 to 414b6d5 Compare October 6, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants