Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

(#1938) Improve Offline Message Debugging Log #1939

Merged
merged 1 commit into from
Jan 7, 2020
Merged

(#1938) Improve Offline Message Debugging Log #1939

merged 1 commit into from
Jan 7, 2020

Conversation

hoffmabc
Copy link
Member

Fixes #1938

@hoffmabc hoffmabc added feature Feature or enhancement to openbazaar-go refactoring 🔍 readyForReview Issue or PR ready for code review prior to closing. ordering ordering issues labels Dec 19, 2019
@hoffmabc hoffmabc added this to the Ethereum Launch 🚀 milestone Dec 19, 2019
@hoffmabc hoffmabc requested review from placer14 and cpacia December 19, 2019 16:01
@hoffmabc hoffmabc self-assigned this Dec 19, 2019
@coveralls
Copy link

coveralls commented Dec 19, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.008%) to 38.41% when pulling b58b10e on brian.improveOfflineMessages into 03c9055 on master.

@cpacia
Copy link
Member

cpacia commented Dec 19, 2019

Can you change these logs to warningf

@drwasho drwasho changed the title Improve Offline Message Debugging Log (#1938) Improve Offline Message Debugging Log Dec 19, 2019
@OpenBazaar OpenBazaar deleted a comment from szollo Dec 19, 2019
placer14
placer14 suggested changes Dec 19, 2019
View reviewed changes
Copy link
Member

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You accidentally included the precision change in this PR. Please remove. Also, the point of this improvement was to include the message ID in the log output so we can match it with the message ID from the sender and can prove positively that the message wasn't dropped because it's for another user.

net/retriever/retriever.go Outdated Show resolved Hide resolved
@drwasho drwasho added the ethereum Ethereum integration-related issues. label Dec 20, 2019
@hoffmabc hoffmabc force-pushed the brian.improveOfflineMessages branch 2 times, most recently from 19cf5be to 8d2e268 Compare December 20, 2019 13:54
@hoffmabc
Copy link
Member Author

Ok @placer14 take a look?

@cpacia cpacia added needs rebase and removed 🔍 readyForReview Issue or PR ready for code review prior to closing. needs rebase labels Jan 6, 2020
placer14
placer14 approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If we like, we can direct it to master then it can be released at the earliest possible moment instead of waiting for ETH.

@placer14 placer14 changed the base branch from ethereum-master to master January 6, 2020 22:37
@placer14 placer14 force-pushed the brian.improveOfflineMessages branch from 34ef0f8 to b58b10e Compare January 6, 2020 22:37
@placer14
Copy link
Member

placer14 commented Jan 6, 2020

I squashed the previously approved changes into a single commit, rebased this commit onto master, and adjusted this PR to merge into master.

@placer14 placer14 merged commit cfc5ce4 into master Jan 7, 2020
@placer14 placer14 modified the milestones: Ethereum Launch 🚀, 0.13.8 Jan 7, 2020
@placer14 placer14 deleted the brian.improveOfflineMessages branch January 7, 2020 03:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@placer14 placer14 placer14 approved these changes

@cpacia cpacia cpacia approved these changes

Assignees

@hoffmabc hoffmabc

Labels
ethereum Ethereum integration-related issues. feature Feature or enhancement to openbazaar-go ordering ordering issues refactoring
Projects
None yet
Milestone
0.13.8
Development

Successfully merging this pull request may close these issues.

Improve Error Logging for unable to decrypt offline message Message
5 participants
@hoffmabc @coveralls @cpacia @placer14 @drwasho