This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Manually send order messages and trigger offline message scan #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Initial conversation around this improvement suggests we will move forward with this PR, pending final peer review of the implementation. |
placer14
suggested changes
May 20, 2019
…ve of all messages
placer14
suggested changes
Jul 10, 2019
placer14
suggested changes
Jul 17, 2019
repo/db/messages_test.go
Outdated
|
|
||
| fmt.Println(string(retMsg.GetPayload().Value), " ", peer) | ||
|
|
||
| if !(string(retMsg.GetPayload().Value) == payload) { |
placer14
approved these changes
Jul 24, 2019
There was a problem hiding this comment.
The only other concern which was unaddressed is https://github.com/OpenBazaar/openbazaar-go/pull/1584/files#r301834135 but not worth holding this PR longer. Excellent work here, @amangale.
placer14
suggested changes
Jul 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds order_messages table which is used to store order related messages for a node. It also adds two api end points : GET
/ob/scanofflinemessagesand POST/ob/sendordermessageto manually trigger offline message scan and send any previously sent order message of type - Message_ORDER, Message_ORDER_REJECT, Message_ORDER_CANCEL, Message_ORDER_CONFIRMATION, Message_ORDER_FULFILLMENT, Message_ORDER_COMPLETION.Fixes #1459
Fixes #1584