-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand on DemoReplayStrategy #24 #56
Conversation
… the string to indicate whether the screen changed
Thank you @dianzrong ! Can you please add instructions as per #33 (comment), e.g.
If I run:
I get:
|
@dianzrong thank you for the great work! Please grab some time on my calendar at your earliest convenience on Weds/Thurs this week: https://www.getclockwise.com/c/richard-abrich/quick-meeting |
@dianzrong if I run
What version of gensim did you install? |
@dianzrong can you please comment on your approach? i.e. why did you choose to implement this:
Can you please show some examples of pairs of raw and summarized ascii/ocr? Thank you! 🙏 |
@abrichr Thank you for your comments. I used gensim==3.8.2 as gensim.summarization was removed in later versions. However, I just noticed this relies on out of date Python functions so I will implement the summarization a different way. |
@abrichr After implementing it differently, I have the following output. The ASCII doesn't read text very well so my implementation of it doesn't seem very useful. ASCII:
summarized ASCII:
OCR:
Summarized OCR:
|
Excellent work! Can you please refactor this into a |
What is next here? |
Summary (#24):
This pull request summarized the OCR text of the current and previous screenshots. Then, the summaries are compared, to see if the screen has changed. The change is then noted in the prompt.
Assumptions:
The screen can summarized by 1 word. This may not be true for more complex screens such as those with multiple windows open simultaneously.
External Libraries:
Next Steps: