-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(share): add sharing using magic-wormhole #223
Merged
Mustaballer
merged 81 commits into
OpenAdaptAI:main
from
Mustaballer:share-magic-wormhole
Dec 12, 2023
Merged
feat(share): add sharing using magic-wormhole #223
Mustaballer
merged 81 commits into
OpenAdaptAI:main
from
Mustaballer:share-magic-wormhole
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0dm
reviewed
Jun 7, 2023
abrichr
reviewed
Jun 14, 2023
Please resolve merge conflicts 🙏 |
Will do :) |
abrichr
reviewed
Jun 16, 2023
abrichr
reviewed
Jun 16, 2023
abrichr
reviewed
Jun 16, 2023
abrichr
reviewed
Jun 16, 2023
abrichr
changed the title
Add Publishing using magic-wormhole #46
Add Sharing using magic-wormhole #46
Jun 19, 2023
…/puterbot into share-magic-wormhole
Ready for review! I addressed the comments you've had :) |
@abrichr Ready for Review! |
abrichr
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adding my TODOs would be great, once CI passes please feel free to merge 🙏
Excellent work @Mustaballer !! 🚀
Co-authored-by: Richard Abrich <richard.abrich@gmail.com>
Co-authored-by: Richard Abrich <richard.abrich@gmail.com>
R-ohit-B-isht
pushed a commit
to R-ohit-B-isht/OpenAdapt
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Unit Tests Created
test_export_recording_to_folder
: Tests the exporting of a recording to a folder. It creates a temporary recording database file and checks that the exported zip file path is notNone
and exists.test_send_file
: Verifies the sending of a file. It creates a temporary file and checks that thesubprocess.run()
function is called with the correct arguments.test_send_recording
: Ensures the sending of a recording. It mocks the necessary functions and verifies that bothexport_recording_to_folder()
andsend_file()
are called.test_receive_recording
: Validates the receiving of a recording. It mocks thesubprocess.run()
function and checks that it is called with the correct arguments.Steps to QA
After creating a recording, run these following commands in your venv environment
python -m puterbot.share send --recording_id=1
python -m puterbot.share receive --wormhole_code=<wormhole_code>