[rust-server] Cope with base paths with trailing '/' #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 4, 2018 15:37
Since we're concatenating as strings, we need to strip any training '/'.
See #951 for the motivation behind this change
|
#967 does this better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.Description of the PR
Since we're concatenating URL path segments as strings, we need to strip any trailing '/'.
Of course, the correct fix would be to use the
Urltype and perform the concatenation correctly. This is just a quick fix to ensure thatrust-serverstops mangling the URL when no base_path is provided (we've been exposed by the recent update to swagger-parser - see #951).I've also renamed
base_pathtobase_urlin a file where it was actually a URL being referenced, and tidied up some imports.The renaming is a change to the public API. However, it's fully back-compatible.