[java][native] Remove JAX-RS dependency from generated java-native client. #9585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependency on JAX-RS from the Java native client template by making the following changes:
Remove use of GenericType
This was originally introduced in [Java][Native] Support oneOf/anyOf schemas #7263 by presumably copy pasting a piece of code for OneOf/AnyOf support from the Jersey client. It was using
GenericType
from JAX-RS, which seems unnecessary since it doesn't seem to generate generic type instantiations (the anyOf/oneOf deserializer will also use{{.}}.class
, and not GenericType or similar type tokens).Remove ContextResolver implementation
The
JSON
class implements the JAX-RS ContextResolver interface, which seems unnecessary for a native Java client in a non JAX-RS environment (probably copy paste)Removed the respective dependencies from build.gradle/pom.xml.
[OPTIONAL] Set source encoding to UTF-8 in build.gradle
I had to set the source encoding in the build.gradle template, as the samples were not even building for me otherwise.
The pet store API spec seems to contain UTF-8 characters which are copied into the source, breaking the build with windows default encoding for me. (This should probably be split into a separate PR; but I was unable to build and validate the sample without this fix).
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)