Move "ensure-up-to-date" execution to CircleCI #944
Conversation
CI/circle_parallel.sh
Outdated
| @@ -8,6 +8,10 @@ if [ "$NODE_INDEX" = "1" ]; then | |||
| cp CI/pom.xml.circleci pom.xml | |||
| java -version | |||
| mvn --quiet verify -Psamples | |||
| elif [ "$NODE_INDEX" = "2" ]; then | |||
| echo "Running node $NODE_INDEX to test ensure-up-to-date" | |||
| mvn clean package -DskipTests -Dmaven.javadoc.skip=true | |||
There was a problem hiding this comment.
"mvn clean install" was run before running this script (https://github.com/OpenAPITools/openapi-generator/pull/944/files#diff-29944324a3cbf9f4bd0162dfe3975d88R69) so I don't think we need to do it again or I probably miss the reason behind.
There was a problem hiding this comment.
It is just a matter of having modules/openapi-generator-cli/target/openapi-generator-cli.jar. I have put here the command that is sufficient to produce it (with a clean to be sure that it gets updated).
There was a problem hiding this comment.
On shippable, there was already a mvn clean install, so what I did is just moving it before ensure-up-to-date with the initial commit:
There was a problem hiding this comment.
Or do you mean here line 69:
Lines 68 to 70 in baa70e5
OK I agree we do not need to redo it. I will remove the line.
|
Commit df18063 added to see if ensure-up-to-date is working. CircleCI should be red. |
* bin/java-petstore-rest-assured.sh to update "samples/"
|
Error as expected:
Important: you need to switch to the second tab |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.Description of the PR
Extracted from PR #929:
@wing328 proposed to move execution of
ensure-up-to-date(see #80) to CircleCI.This PR does the change and I will perform some checks to ensure that it works as expected.