Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imports for inner items of arrays/maps in composed schemas #9268

Merged
merged 6 commits into from
Jun 18, 2021

Conversation

zippolyte
Copy link
Contributor

For typescript at least, we need to import the inner items of complex types of the composed schemas. This PR adds it.
There might be a better/cleaner way to do this, I'm using the fromProperty method to re-use existing algorithm and have the complexType property and import them all.
Please advise if it should be done another way.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@zippolyte
Copy link
Contributor Author

zippolyte commented Apr 15, 2021

@wing328 @jimschubert if you could have a look at this 🙂

No sure why travis and appveyor have different behaviours with the generation, looks like there is generate-alias-as-model set to true in travis, because travis generates the set of oneOf as [Apple, Banana, Grapes] while appveyor generates it as [Apple, Array<Grape>, Banana] for the same test (in RubyClientCodegenTest.java:367)

@zippolyte
Copy link
Contributor Author

@wing328 @jimschubert, any ideas on this ? Why the different CI don't generate the same things for ruby unit tests ?

@therve
Copy link
Contributor

therve commented May 3, 2021

@wing328 @jimschubert @cbornet @ackintosh @jmini @etherealjoy @spacether we fixed the CI, thanks for taking a look 🙇 .

@wing328
Copy link
Member

wing328 commented Jun 18, 2021

LGTM. Sorry for taking so long to review as there are just too many PRs.

@wing328 wing328 merged commit 7389446 into OpenAPITools:master Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants