-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL) #9192
base: master
Are you sure you want to change the base?
[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL) #9192
Conversation
…ter became annotated with `@InputFile`. However, the `@InputFile` annotation is not suitable for `String` to `File` conversion in the case of the `URL` specification location. `CodegenConfigurator.toContext()` method eagerly converts the `inputSpec` parameter to the `OpenAPI` instance via `OpenAPIParser.readLocation`. Added a remote specification project generation test and a WireMock dependency
…" for build success
@get:InputFile | ||
@PathSensitive(PathSensitivity.RELATIVE) | ||
@Optional | ||
@Input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would unfortunately mean that even if the input specification in a local file changed, the task would be up-to-date because it's only checking the filename but not its contents.
Maybe splitting the input specification location into local specs and remote specs would make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joschi, if I extend this PR with the solution to check the modification status of the remote source will it do the trick? I mean let's imagine that the Up-to-date check works with the Url/Path then will you agree to use specificationUrl?
Fixes: #8255
@InputFile
and@PathSensitive
annotations with@Optional
and@Input
annotations for theinputSpec
parameterRelated PR #6716 change: here
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example,
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x