Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAXRS-spec] Added support for cookie parameters #8117

Merged
merged 1 commit into from
Dec 8, 2020
Merged

[JAXRS-spec] Added support for cookie parameters #8117

merged 1 commit into from
Dec 8, 2020

Conversation

alfabetacain
Copy link
Contributor

@alfabetacain alfabetacain commented Dec 7, 2020

Added support for cookie parameters to the jaxrs-spec generator, which should fix #2908.
Added the test case testGenerateApiWithCookieParameter_issue2908 to JavaJAXRSSpecServerCodegenTest.java, which uses the file issue_2908.yaml for testing that cookie parameter generation works.
Briefly, the fix was adding a new mustache template (cookieParams.mustache) to the jaxrs-spec generator and referencing it in api.mustache in the same way the other parameter types are referenced (e.g. queryParams.mustache).
The new cookieParams.mustache is essentially a copy of the queryParams.mustache.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

@wing328
Copy link
Member

wing328 commented Dec 8, 2020

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@alfabetacain
Copy link
Contributor Author

Wrong email used. Thanks a lot :-)
I've pushed an amended commit (just changed the author)

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 9e0badb into OpenAPITools:master Dec 8, 2020
@alfabetacain alfabetacain deleted the fix_issue2908 branch December 8, 2020 07:37
wing328 pushed a commit that referenced this pull request Oct 3, 2023
{{>cookieParams}} was introduced to generated classes but not for the only interface use case in #8117
AlanCitrix pushed a commit to AlanCitrix/openapi-generator that referenced this pull request Oct 26, 2023
{{>cookieParams}} was introduced to generated classes but not for the only interface use case in OpenAPITools#8117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [JAVA | JAXRS-Spec] Cookie in parameter is not correctly generated
2 participants