Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #8014, _check_type flag not being honored. #8053

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

fbl100
Copy link
Contributor

@fbl100 fbl100 commented Nov 30, 2020

Updated model_utils.mustache to pass the check_type flag into attempt_convert_item(). Failure to do so
results in type validation errors occurring when the user has specifically requested that they be disabled.

@spacether if this is not the 'right' way to fix this, then I may need some assistance with my model. This fix works for my code.

Fixes:
#8014

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • @[x] Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Updated model_utils.mustache to pass the check_type flag into attempt_convert_item(). Failure to do so
results in type validation errors occurring when the user has specifically requested that they be disabled.
@fbl100
Copy link
Contributor Author

fbl100 commented Nov 30, 2020

Regarding the failure in the CircleCI build... I don't understand why this is failing. The test in question appears to be using a java client, and this PR does not touch the java client.

@fbl100 fbl100 marked this pull request as draft December 3, 2020 17:04
@fbl100 fbl100 marked this pull request as ready for review December 3, 2020 17:05
@spacether spacether added this to the 5.0.0 milestone Dec 7, 2020
@spacether spacether changed the title Fixes issue 8014, _check_type flag not being honored. Fixes issue #8014, _check_type flag not being honored. Dec 7, 2020
Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! This looks great!

Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@spacether spacether merged commit 99d8371 into OpenAPITools:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Python] validate_and_convert_types does not pass _check_type to attempt_convert_item
2 participants