[FIX][CLI] handle null result messages #7472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swagger-parser has the potential to return null
for messages which will throw NPE on
initialization of the validationMessages hashset.
rather that allow this to happen we will assume
that a null message collection represents an empty
collection and continue.
Fixes #7453
This prevents a null pointer exception when the swagger-parser library returns a null on
getMessages()
. Rather than instantiate the validation HashSet with null, we will pass an empty list.In my case I was experiencing this null pointer exception because swagger-parser has a bug which returns null for all fields when parameters are not passed in.
While this does not fix that issue, it allows a much more friendly run time exception to be thrown that states
Exception in thread "main" java.lang.RuntimeException: missing OpenAPI input!
There seems to be a swagger-parser issue for this over here ==> swagger-api/swagger-parser#1428
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH.master