Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Use canonical path for template dir #7388

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

zippolyte
Copy link
Contributor

Use the canonical path of templateDir instead of absolute path in order to get rid of .. when specifying a relative templateDir like -t ../../templates in the command line, and avoid raising the new exception introduced in #6598: IllegalArgumentException("Template location must be constrained to template directory.")

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@auto-labeler
Copy link

auto-labeler bot commented Sep 10, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@zippolyte
Copy link
Contributor Author

cc @jimschubert as you authored the PR #6598

@wing328
Copy link
Member

wing328 commented Sep 10, 2020

cc @OpenAPITools/generator-core-team as well

@zippolyte
Copy link
Contributor Author

Friendly bump on this one, it's currently preventing us from upgrading openapi-generator to the master and enjoying the latest 🙂

@jimschubert jimschubert merged commit 8dd3e56 into OpenAPITools:master Sep 14, 2020
@zippolyte zippolyte deleted the hippo/tdap branch September 15, 2020 10:02
@wing328 wing328 added this to the 5.0.0 milestone Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants