Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Resteasy] Remove duplicate jackson-datatype-jsr310 dependency #7338

Conversation

Edubits
Copy link
Contributor

@Edubits Edubits commented Sep 3, 2020

The jackson-datatype-jsr310 dependency is imported twice when the java8 option is enabled. As the dependency is also imported unconditionally I removed the conditional one.

PR checklist

  • [x ] Read the contribution guidelines.
  • [ x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ x] If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • [x ] Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • [ x] File the PR against the correct branch: master
  • [ x] Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda

@wing328 wing328 added this to the 5.0.0 milestone Sep 4, 2020
@wing328 wing328 merged commit 5e512e8 into OpenAPITools:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants