Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpprestsdk] Fix broken non-mockable builds due to conflicting destructors #732

Merged
merged 1 commit into from
Aug 12, 2018
Merged

[cpprestsdk] Fix broken non-mockable builds due to conflicting destructors #732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/cpp-rest-sdk-client/api-header.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public:
~{{classname}}() override;
{{/gmockApis}}
{{^gmockApis}}
virtual ~{{classname}}() = default;
virtual ~{{classname}}();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this impact behavior for mockable codegen?

{{/gmockApis}}

{{#operation}}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/cpp-restsdk/api/PetApi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class PetApi

explicit PetApi( std::shared_ptr<ApiClient> apiClient );

virtual ~PetApi() = default;
virtual ~PetApi();

/// <summary>
/// Add a new pet to the store
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/cpp-restsdk/api/StoreApi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class StoreApi

explicit StoreApi( std::shared_ptr<ApiClient> apiClient );

virtual ~StoreApi() = default;
virtual ~StoreApi();

/// <summary>
/// Delete purchase order by ID
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/cpp-restsdk/api/UserApi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class UserApi

explicit UserApi( std::shared_ptr<ApiClient> apiClient );

virtual ~UserApi() = default;
virtual ~UserApi();

/// <summary>
/// Create user
Expand Down