-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JAVA][Rest-assured] Added constants #697
Conversation
918cf60
to
c272f39
Compare
@viclovsky thanks for the PR. cc technical committee: |
public static final String REQ_URI = "{{path}}"; | ||
public static final String SUMMARY = "{{{summary}}}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@viclovsky what's the use case for this constant storing the summary (which is included in the javadoc string above)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constants are necessary to fill report.
Rest-assured is mostly client for testing. Tests often has integration with test report (such as Allure). Test report has detailed information about tests run results, curl arguments, command line etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@viclovsky thanks for the explanation 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also intended to do the same with tags, but I haven't found easy way to do it.
@viclovsky : the changes you made to the javadoc prevent the project to compile. When I run this:
I get some errors like this:
See #43 for reference. @wing328: why is the CI not catching this? |
@jmini no idea off the top of my head at the moment as the CI results are all green. I'll take a look at the log later to see if there are any clues |
UPDATE: I'm looking into the issue and trying to fix the CI (which should report red instead) |
Performed some more tests and CI (CircleCI) was able to report syntax errors with the Java rest-assured client. Still not entirely sure why the Javadoc error was missed (and I was able to repeat the Javadoc error locally) |
I saw those changes to the javadoc, but did not think they should cause any issues. I guess the java doc generation is where things break. Is that right? |
Here is the error I got locally:
We suspect CircleCI failed to detect the error due to an old version of JDK8 used in the build environment. |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,4.0.x
. Default:master
.Description of the PR
Added constant "httpMethod", "summary" and fixed javadoc for "returnType", "dataType".