-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kotlin] Make ApiClient in jvm-retrofit2 be able to use own OkHttpClient #6855
[Kotlin] Make ApiClient in jvm-retrofit2 be able to use own OkHttpClient #6855
Conversation
Update my fork
Update my fork
update my fork
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
cc @jimschubert (2017/09), @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) |
|
||
private var okHttpClient?: OkHttpClient = null | ||
|
||
constructor( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tgerth we don't need a new constructor, you can add the private val okHttpClient : OkHttpClient? = null
to the constructor at line 18, because it has a default value.
And with this change, you can remove this constructor, and the var in line 49.
The commit history contains many changes (commits) not related to this PR. Better create a new PR by cherry-picking the commits related to Kotlin. |
PR checklist
./bin/generate-samples.sh bin/configs/kotlin-jvm-retrofit2*
.master
similar to PR: #6699