Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Add add constructor to BYO OkHttpClient #6401

Merged

Conversation

jonnii
Copy link
Contributor

@jonnii jonnii commented May 22, 2020

The intention of this change is to allow someone to supply their own OkHttpClient to the ApiClient in the event that they don't want to pay the price for creating a new client even when if they're going to setHttpClient.

A specific example of this is if you have multiple ApiClients (e.g. imagine a user service and an avatar service) which have different API contracts but could share the same DNS/caching/resiliency settings etc...

I appreciate that this could be solved with a custom template but this felt useful enough to contribute.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jonnii
Copy link
Contributor Author

jonnii commented May 23, 2020

@wing328 Any suggestions on what else is required to get this in and/or feedback would be greatly appreciated!

@jonnii jonnii force-pushed the add-constructor-to-take-http-client branch from 1d63ab5 to 3c2c4bd Compare May 26, 2020 16:25
@jonnii jonnii force-pushed the add-constructor-to-take-http-client branch from 3c2c4bd to b28d720 Compare May 27, 2020 13:15
@wing328 wing328 merged commit 1a2097e into OpenAPITools:master Jun 15, 2020
@wing328 wing328 added this to the 5.0.0 milestone Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants