Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MARKDOWN] fix property and parameter names #6105

Merged
merged 5 commits into from
Aug 1, 2020

Conversation

TetianaServirog
Copy link
Contributor

@TetianaServirog TetianaServirog commented Apr 29, 2020

Fixes #6089
markdown generator escapes all default special characters (for example $) in parameter and property names with their default mapping (Dollar respectively).
This PR overrides special characters mapping and removes default camelization behavior for parameters in order to document names as is.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@ybelenko ybelenko requested a review from jimschubert May 5, 2020 14:38
@jimschubert jimschubert self-assigned this Aug 1, 2020
@jimschubert jimschubert added this to the 5.0.0 milestone Aug 1, 2020
@jimschubert
Copy link
Member

Looks great. Thanks!

@jimschubert jimschubert merged commit 828bdeb into OpenAPITools:master Aug 1, 2020
jimschubert added a commit that referenced this pull request Aug 3, 2020
* master: (121 commits)
  [PowerShell] better publishing workflow (#7114)
  [aspnetcore] Typo issues in docs and generated code (#7094)
  fix http signaure auth in build.sbt (#7110)
  fix for the issue facing spec invlolving arrayschema structure with ref (#6310)
  [csharp-netcore] added cancellation tokens to async calls (#7077)
  [PS] Allow CI to publish the module (#7091)
  [Dart] Treat float as double (#6924)
  [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096)
  move maven,gradle tests to shipppable ci (#7108)
  [MARKDOWN] Fix issue 6089 with property and parameter names (#6105)
  [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073)
  [online] Fix for version conflicts with springfox/boot (#7102)
  skip some installations to shorten build time
  [Go][Exp] better code format (#7088)
  Fix Shippable CI (#7097)
  typescript-node: clean up require and import (#6947)
  commented out perl, bash tests to reduce build time
  Add a link to conference paper (#7086)
  Add a link to the blog post at qiita (#7084)
  migrate typescript.sh to new config format (#7078)
  ...
@wing328 wing328 changed the title [MARKDOWN] Fix issue 6089 with property and parameter names [MARKDOWN] fix property and parameter names Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants