Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php-symfony] Fix return type in model setters. #6085

Merged
merged 3 commits into from
Apr 30, 2020
Merged

[php-symfony] Fix return type in model setters. #6085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b7c075
Fix return type in model setters.
reznikartem Apr 28, 2020
07dd971
Add return self type hint for setters
reznikartem Apr 29, 2020
ace7f23
Revert "Add return self type hint for setters"
reznikartem Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/php-symfony/model_generic.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class {{classname}} {{#parentSchema}}extends {{{parent}}} {{/parentSchema}}
*
* @return $this
*/
public function {{setter}}({{#vendorExtensions.x-parameter-type}}{{vendorExtensions.x-parameter-type}} {{/vendorExtensions.x-parameter-type}}${{name}}{{^required}} = null{{/required}}){{#vendorExtensions.x-parameter-type}}: {{^required}}?{{/required}}{{vendorExtensions.x-parameter-type}}{{/vendorExtensions.x-parameter-type}}
public function {{setter}}({{#vendorExtensions.x-parameter-type}}{{vendorExtensions.x-parameter-type}} {{/vendorExtensions.x-parameter-type}}${{name}}{{^required}} = null{{/required}})
{
$this->{{name}} = ${{name}};

Expand Down
2 changes: 1 addition & 1 deletion samples/server/petstore/php-symfony/SymfonyBundle-php/Model/Order.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ public function getShipDate(): ?\DateTime
*
* @return $this
*/
public function setShipDate(\DateTime $shipDate = null): ?\DateTime
public function setShipDate(\DateTime $shipDate = null)
{
$this->shipDate = $shipDate;

Expand Down
6 changes: 3 additions & 3 deletions samples/server/petstore/php-symfony/SymfonyBundle-php/Model/Pet.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ public function getCategory(): ?Category
*
* @return $this
*/
public function setCategory(Category $category = null): ?Category
public function setCategory(Category $category = null)
{
$this->category = $category;

Expand Down Expand Up @@ -203,7 +203,7 @@ public function getPhotoUrls(): array
*
* @return $this
*/
public function setPhotoUrls(array $photoUrls): array
public function setPhotoUrls(array $photoUrls)
{
$this->photoUrls = $photoUrls;

Expand All @@ -227,7 +227,7 @@ public function getTags(): ?array
*
* @return $this
*/
public function setTags(array $tags = null): ?array
public function setTags(array $tags = null)
{
$this->tags = $tags;

Expand Down