-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Go] Interface definitions for api functions #5914
Merged
+3,968
−1,691
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
bf0968b
[Go]: Interface definitions for api functions
arvindth a3454a3
Use interface in client struct
arvindth 1b50c28
Fixups to align with current master
arvindth a06ed94
Replace classname with method name in method comments
arvindth b5abc28
Make method comments a bit prettier
arvindth 7bca6e0
Add commandline option to enable generateInterfaces
arvindth 9822d5c
Update go-petstore & oa3/go-petstore samples with prettier comments
arvindth 9653a67
Enable generateInterfaces and update samples for go-petstore-withxml
arvindth 75cfe81
Add generateInterfaces/prettier comments for go-experimental templates
arvindth fc00c98
Method signature refactors for go-experimental (and openapi3) samples
arvindth 16c2141
Enable generateInterfaces for go-experimental samples
arvindth 9ac3de2
Undo mock additions in CI/backward incompatibility in tests
arvindth 3398492
Address PR comments: fix backward incompatibility in templates
arvindth 4945c11
Regenerate go-experimental/oas2 samples w/o interfaces
arvindth fdc4599
Regenerate go-experimental/oas2 samples with interfaces
arvindth 9d6ca29
Add mock to test go-experimental interface
arvindth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Address PR comments: fix backward incompatibility in templates
- add Execute redirection from request back up to service
commit 339849280b61ec9e063436dd8fe04ee6d6898430
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than requiring callers to call the new backward incompatible *Execute methods in Service directly, I've re-added the original Execute method in *Request, which just redirects the call to the Service's *Execute, in order to maintain backward compatibility.