-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] remove deprecated jackson classes #5786
[Java] remove deprecated jackson classes #5786
Conversation
This should now be at the point where we just have some test failures due to a change in behaviour, is there any reason why Jackson classes are being used to do this date parsing rather than just SimpleDateFormat and java.util.time classes? |
…cated-jackson-classes # Conflicts: # samples/client/petstore/java/jersey2/src/main/java/org/openapitools/client/RFC3339DateFormat.java
@jonfreedman Don't recall the reason. Can you please resolve the merge conflicts when you've time? Thanks again and sorry for the delay in reviewing. |
Closed via #7304 |
Thanks for merging, I was going to take a look at this next week as I'm currently on holiday, I need to check if the webclient generator needs the same fix |
fixes #5779
Removes references to ISO8601DateFormat and ISO8601Utils both of which are deprecated since Jackson 2.9.0 and replace with StdDateFormat
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda