Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript-angular: fix zone-js version for angular 8 #5585

Merged
merged 1 commit into from
Mar 12, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
typescript-angular: fix zone-js version for angular 8
macjohnny committed Mar 12, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit a9259c92f94ab2161802fb3c709536101e055261
Original file line number Diff line number Diff line change
@@ -330,7 +330,7 @@ private void addNpmPackageGeneration(SemVer ngVersion) {
}

// set zone.js version
if (ngVersion.atLeast("8.0.0")) {
if (ngVersion.atLeast("9.0.0")) {
additionalProperties.put("zonejsVersion", "0.10.2");
} else if (ngVersion.atLeast("8.0.0")) {
additionalProperties.put("zonejsVersion", "0.9.1");
Original file line number Diff line number Diff line change
@@ -30,7 +30,7 @@
"rxjs": "^6.5.0",
"tsickle": "^0.35.0",
"typescript": ">=3.4.0 <3.6.0",
"zone.js": "^0.10.2"
"zone.js": "^0.9.1"
},
"publishConfig": {
"registry": "https://skimdb.npmjs.com/registry"
Original file line number Diff line number Diff line change
@@ -30,7 +30,7 @@
"rxjs": "^6.5.0",
"tsickle": "^0.35.0",
"typescript": ">=3.4.0 <3.6.0",
"zone.js": "^0.10.2"
"zone.js": "^0.9.1"
},
"publishConfig": {
"registry": "https://skimdb.npmjs.com/registry"
Original file line number Diff line number Diff line change
@@ -30,7 +30,7 @@
"rxjs": "^6.5.0",
"tsickle": "^0.35.0",
"typescript": ">=3.4.0 <3.6.0",
"zone.js": "^0.10.2"
"zone.js": "^0.9.1"
},
"publishConfig": {
"registry": "https://skimdb.npmjs.com/registry"