Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-angular]: objects as query parameters no longer break when fields are null #5197

Merged
merged 5 commits into from
Feb 3, 2020
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,11 @@ export class {{classname}} {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if (value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,11 @@ export class PetService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
daniel-frak marked this conversation as resolved.
Show resolved Hide resolved
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,11 @@ export class StoreService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,11 @@ export class UserService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,11 @@ export class PetService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,11 @@ export class StoreService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,11 @@ export class UserService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,11 @@ export class PetService implements PetServiceInterface {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,11 @@ export class StoreService implements StoreServiceInterface {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,11 @@ export class UserService implements UserServiceInterface {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ export class PetService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ export class StoreService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ export class UserService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,11 @@ export class PetService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,11 @@ export class StoreService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,11 @@ export class UserService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ export class PetService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ export class StoreService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ export class UserService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ export class PetService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ export class StoreService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ export class UserService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,11 @@ export class PetService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ export class StoreService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ export class UserService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,11 @@ export class PetService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ export class StoreService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ export class UserService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ export class PetService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ export class StoreService {
return httpParams;
}

private addToHttpParamsRecursive(httpParams: HttpParams, value: any, key?: string): HttpParams {
private addToHttpParamsRecursive(httpParams: HttpParams, value?: any, key?: string): HttpParams {
if(value == null) {
return httpParams;
}

if (typeof value === "object") {
if (Array.isArray(value)) {
(value as any[]).forEach( elem => httpParams = this.addToHttpParamsRecursive(httpParams, elem, key));
Expand Down
Loading