Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] Minor enhancement to C client generator #4457

Merged
merged 1 commit into from
Nov 13, 2019
Merged

[C] Minor enhancement to C client generator #4457

merged 1 commit into from
Nov 13, 2019

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Nov 12, 2019

  • fix readme to remove references to petstore
  • fix CMakelist to remove references to PetAPI, etc
  • avoid overriding CMakelist so as to keep the Petstore test

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@auto-labeler
Copy link

auto-labeler bot commented Nov 12, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 4.2.1 milestone Nov 12, 2019
@wing328 wing328 merged commit fa1e003 into master Nov 13, 2019
@wing328 wing328 deleted the c-enhancement branch November 13, 2019 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant