[C] Update build-and-test.bash #4055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add check for non autogenerated test file
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
4 tasks
Add instructions on how to test petstore sample manual tests.
wing328
reviewed
Oct 7, 2019
| @@ -64,6 +64,8 @@ once compile, you can run it with ``` ./main ``` | |||
|
|
|||
| Note: You dont need to specify includes for models and include folder seperately as they are path linked. You just have to import the api.h file in your code, the include linking will work. | |||
|
|
|||
| ## Test petstore sample | |||
There was a problem hiding this comment.
@zhemant thanks for the PR but I don't think we should add petstore specified instruction in the template as the spec provided by the user may have nothing to do with Petstore.
There was a problem hiding this comment.
Ok I understand, Then I will modify the README to guide how to compile the user code with the generated code. That was the reason I referenced how it will happen in petstore. I will push another commit
There was a problem hiding this comment.
Closing this as there's no update for a while. Please open a new one when you've time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add check for non autogenerated test file
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
Due to build of manual test files is commented out in CMakeLists.txt, they are not generated hence build fails.
@Fjolnir-Dvorak