Store multiple bodyParams with mediaType appropriately #3991
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
New to the project, so while I did my best to answer these questions, I know I did not fully grok the release process and some of the larger concerns that may need to be addressed by my change.
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.Not updating any language templates, so I'm guessing I don't need to do this?
master
,4.1.x
,5.0.x
. Default:master
.This doesn't seem to be a breaking change (new to this project though, so I could be missing something), so master?
PR targets core, not a specific programming language.
Description of the PR
Addresses the issue raised in #3990:
DefaultCodgen.fromRequestBody
to return aList<CodegenParameter>
instead of a singleCodegenParameter
(since requestBody's often contain multiple Content Types.bodyParams
when there are multiple Content Types.CodegenParameter
s.